tests/com.espressif.idf.ui.test/src/com/espressif/idf/ui/test/executable/cases/project/IDFProjectLspCdtFunctionalityTest.java (3)

51-54: Ensure reconfigure is deterministically disabled in setupProject().

setupProject() currently toggles the checkbox with click(); if the default changes, it may re‑enable idf.py reconfigure and reintroduce the lingering process. Prefer explicit deselect().

In ProjectTestOperations.setupProject(...):

// replace the .click() with an explicit deselect
SWTBotCheckBox reconfig = bot.checkBox("Run idf.py reconfigure after project creation to initialize the CMake build configuration");
if (reconfig.isChecked()) {
    reconfig.deselect(); // ensure idf.py reconfigure will NOT run
}

Optional: assert the state after deselect() and log it for CI diagnostics.

---

54-54: Async wait may return before indexer/LSP jobs complete.

If flakiness persists, consider switching to the sync variant here or add a targeted wait for CDT indexer/LSP idle before opening files.

---

76-76: Replace fixed sleeps with condition-based waits.

Use TestWidgetWaitUtility to wait for:

• proposals list to become non-empty,
• Problems view rowCount change,
• styled ranges presence for highlighting.

Also applies to: 112-112, 124-124, 138-138

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

tests/com.espressif.idf.ui.test/src/com/espressif/idf/ui/test/executable/cases/project/NewEspressifIDFProjectClangFilesTest.java (8)

7-7: Good switch to assertEquals import. Also unify equals checks.

Since assertEquals is imported, prefer it over assertTrue(expected.equals(actual)) below for clearer diffs.

Apply this diff at Lines 421-426:

-            assertTrue(expectedClangdPath.equals(actualClangdPath));
+            assertEquals(expectedClangdPath, actualClangdPath);

---

188-199: Key change: setupProject + explicit waits is the right fix for Windows hogging.

Nice replacement of idf.py reconfigure with setupProject and a sync wait. Consider removing the fixed sleep to reduce flakiness.

Apply this diff:

-            bot.sleep(1000);
+            // Rely on explicit waits above; avoid fixed sleeps

---

257-267: Use of IDFUtil.getBuildDir is correct; improve naming and null safety.

• Method name should be getExpectedBuildFolderPath (camelCase), not PATH.
• If IDFUtil.getBuildDir(project) returns null, Paths.get(null) will throw NPE. Add a guard and a clearer error.

Example fix:

-    private static String getExpectedBuildFolderPATH(String projectName) throws IOException
+    private static String getExpectedBuildFolderPath(String projectName) throws IOException
     {
         try
         {
             IProject project = ResourcesPlugin.getWorkspace().getRoot().getProject(projectName);
-            String buildFolder = IDFUtil.getBuildDir(project);
+            String buildFolder = IDFUtil.getBuildDir(project);
+            if (buildFolder == null || buildFolder.isBlank()) {
+                throw new IOException("Build directory is not configured for project: " + projectName);
+            }
             Path buildFolderPath = Paths.get(buildFolder);
             return buildFolderPath.toAbsolutePath().toString();
         }

Also update call sites accordingly (e.g., Line 279).

---

397-410: Avoid duplication with build-folder helpers.

This method duplicates logic from getExpectedBuildFolderPATH. Refactor to reuse it and only prepend the flag.

Apply this diff:

-    private static String getExpectedBuildFolderPATHforClangdAdditionalArgument(String projectName)
-            throws IOException
-    {
-        try
-        {
-            IProject project = ResourcesPlugin.getWorkspace().getRoot().getProject(projectName);
-            String buildFolder = IDFUtil.getBuildDir(project);
-            Path buildFolderPath = Paths.get(buildFolder);
-            return "--compile-commands-dir=" + buildFolderPath.toAbsolutePath().toString();
-        }
-        catch (CoreException e)
-        {
-            throw new IOException("Failed to get build directory for project: " + projectName, e);
-        }
-    }
+    private static String getExpectedBuildFolderPathForClangdAdditionalArgument(String projectName)
+            throws IOException
+    {
+        try {
+            String buildPath = getExpectedBuildFolderPath(projectName);
+            return "--compile-commands-dir=" + buildPath;
+        } catch (IOException e) {
+            throw e;
+        }
+    }

And update the call at Line 424 accordingly.

---

413-418: Handle missing toolchain path to avoid NPE.

IDFUtil.getToolchainExePathForActiveTarget() can return null; Paths.get(null) will NPE. Fail fast with a clear message.

Apply this diff:

-        String toolchain = IDFUtil.getToolchainExePathForActiveTarget();
+        String toolchain = IDFUtil.getToolchainExePathForActiveTarget();
+        if (toolchain == null || toolchain.isBlank()) {
+            throw new IOException("Active toolchain not found. Ensure a launch target is selected and toolchain is installed.");
+        }

---

421-426: Prefer assertEquals for clarity and consistent failure output.

Use assertEquals as elsewhere in this class.

-            assertTrue(expectedClangdPath.equals(actualClangdPath));
+            assertEquals(expectedClangdPath, actualClangdPath);

---

454-459: Close Preferences robustly across platform variations.

Button labels vary ("Apply and Close", "Close", "Cancel"). Consider a small helper that clicks the first available among these, then waits.

Example:

-            preferencesShell.bot().button("Cancel").click(); // Or "Apply and Close"
+            if (preferencesShell.bot().button("Apply and Close").isEnabled()) {
+                preferencesShell.bot().button("Apply and Close").click();
+            } else if (preferencesShell.bot().button("Close").isEnabled()) {
+                preferencesShell.bot().button("Close").click();
+            } else {
+                preferencesShell.bot().button("Cancel").click();
+            }

---

461-467: Wait for background operations after target change.

After clicking “Yes”, jobs may start (index rebuild, toolchain detection). Add an explicit async wait to stabilize downstream assertions.

-            preferencesShell.bot().button("Yes").click(); // Or "Apply and Close"
-            TestWidgetWaitUtility.waitWhileDialogIsVisible(bot, "IDF Launch Target Changed", 10000);
+            preferencesShell.bot().button("Yes").click();
+            TestWidgetWaitUtility.waitWhileDialogIsVisible(bot, "IDF Launch Target Changed", 10000);
+            TestWidgetWaitUtility.waitForOperationsInProgressToFinishAsync(bot);

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

tests/com.espressif.idf.ui.test/src/com/espressif/idf/ui/test/executable/cases/project/NewEspressifIDFProjectSDKconfigTest.java (1)

186-195: Deduplicate magic timeout: extract a single constant.

Avoid hardcoding 15000 in multiple places; define a constant and use it in both calls.

Add near the top of Fixture:

private static final int CTAB_APPEAR_TIMEOUT_MS = 15000;

Apply this diff to both call sites:

- TestWidgetWaitUtility.waitForCTabToAppear(bot, "SDK Configuration (sdkconfig)", 15000);
+ TestWidgetWaitUtility.waitForCTabToAppear(bot, "SDK Configuration (sdkconfig)", CTAB_APPEAR_TIMEOUT_MS);

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro